Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch ci #12

Merged
merged 14 commits into from
Jul 29, 2024
Merged

patch ci #12

merged 14 commits into from
Jul 29, 2024

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Jul 19, 2024 •
edited
Loading

Closes: #XXX

Description

fix lists

  • lints
  • module dependencies
  • integration tests

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 self-assigned this Jul 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.30%. Comparing base (c44971b) to head (063b5b7).
Report is 2 commits behind head on canto-v8/develop.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           canto-v8/develop      #12   +/-   ##
=================================================
  Coverage             68.30%   68.30%           
=================================================
  Files                   117      117           
  Lines                 11240    11240           
=================================================
  Hits                   7677     7677           
  Misses                 3088     3088           
  Partials                475      475
Files Coverage Δ
app/rapidgen.go 89.28% <ø> (ø)
app/upgrades.go 48.68% <0.00%> (ø)

@dudong2 dudong2 marked this pull request as ready for review July 29, 2024 05:38
@dudong2 dudong2 requested review from dongsam, zsystm and poorphd July 29, 2024 05:40
zsystm
zsystm approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@zsystm zsystm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Left one minor question for code.

tests/integration_tests/test_filters.py Show resolved Hide resolved
@github-actions github-actions bot added the C:CLI label Jul 29, 2024
@dudong2 dudong2 merged commit c4c9caa into canto-v8/develop Jul 29, 2024
17 of 24 checks passed
@dudong2 dudong2 deleted the patch/ci branch July 29, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poorphd poorphd poorphd approved these changes

@zsystm zsystm zsystm approved these changes

@dongsam dongsam Awaiting requested review from dongsam

Assignees

@dudong2 dudong2

Labels
C:CLI Type: Build Type: CI Type: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dudong2 @codecov-commenter @zsystm @poorphd